fix(db): Do not allow creating objects with wrong parent #543
Conversation
If parent is set to same id as object it might cause loops in some of pipeline programs. Block such updates. Signed-off-by: Denys Fedoryshchenko <[email protected]>
There was a problem hiding this comment.
I am wondering if this check should be in the endpoint handler instead, in api.main just like other checks we have e.g. _verify_user_group_existence.
As this check doesn't concern DB abstraction layer.
What do you think? @nuclearcat
|
Yes, it make sense, at least i will try to rewrite and add it to endpoint. |
|
@JenySadadia after returning to this question i remember why i moved to db layer. When we submit multiple nodes over PUT /nodes call, we are not unrolling nodes in api.main: Line 666 in ce9ea25 But rather forward it to db layer, this is why i moved parent verification in db layer, as otherwise i will have to duplicate same code and unroll hierarchy twice - in main code too. |
Okay. Usually we create sub-nodes rather than updating them with |
If parent is set to same id as object it might cause loops in some of pipeline programs. Block such updates.